🧹 [code health improvement] update bash test replacer string#99
🧹 [code health improvement] update bash test replacer string#99bashandbone merged 4 commits intomainfrom
Conversation
Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Bash replacement test to validate variable interpolation by using a replacer that references the captured match via $A instead of a hardcoded literal string. Sequence diagram for updated Bash replacement test behaviorsequenceDiagram
participant TestRunner
participant test_bash_replace
participant test_replace
participant BashEngine
TestRunner->>test_bash_replace: run()
test_bash_replace->>test_replace: test_replace("echo 123", "echo $A", "log $A")
test_replace->>BashEngine: applyPattern("echo 123", pattern echo $A)
BashEngine-->>test_replace: captures A = 123
test_replace->>BashEngine: applyReplacement("log $A", A = 123)
BashEngine-->>test_replace: "log 123"
test_replace-->>test_bash_replace: ret = "log 123"
test_bash_replace->>test_bash_replace: assert_eq(ret, "log 123")
test_bash_replace-->>TestRunner: success
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Updates the Bash language replacement test to validate variable capture/interpolation in the replacement string, aligning the test with the intended ast-grep pattern/replacer behavior for Bash.
Changes:
- Updated
test_bash_replaceto uselog $Aas the replacer instead of a hardcodedlog 123. - Removed the now-obsolete TODO comment about changing the replacer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
🎯 What: Updated the test replacement string in
test_bash_replacefromlog 123tolog $A. This successfully resolves theTODO: change the replacer to log $Acomment incrates/language/src/bash.rs.💡 Why: This changes the test from simply verifying a hardcoded string substitution to testing variable interpolation during the replacement process. Using
log $Achecks that$Ais properly capturing the match123fromecho 123, which provides a much more robust and accurate test of the ast-grep pattern matching and replacement engine for Bash code. It improves the quality and intent of the test coverage.✅ Verification: Ran
cargo test -p thread-language test_bash_replaceto ensure the specific test passes and also rancargo +nightly test --workspace --no-runto ensure the workspace compiles successfully without introducing errors.✨ Result: Improved test case coverage by actively testing variables correctly in bash code replacements without changing functional behavior.
PR created automatically by Jules for task 761935811020712664 started by @bashandbone
Summary by Sourcery
Tests: